Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect aggregation of KZG benchmark results #409

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

tessico
Copy link
Contributor

@tessico tessico commented Nov 11, 2023

Description

commit and open are unaffected much as they don't require precomputation to run the benchmarks. verify needs to first call commit and then open on the same poly, and the bench was calculating the total time to execute the method (i.e. commit + open + verify), not the elapsed time spent only in verify.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

We need to provide a custom timing `iter_custom` which respects the returned duration and aggregates the results across multiple executions.
@tessico tessico marked this pull request as ready for review November 14, 2023 08:46
Copy link
Contributor

@mrain mrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge after CI.

@mrain mrain merged commit bf1a6df into EspressoSystems:main Jan 18, 2024
4 checks passed
@tessico tessico deleted the fix-pcs-benches branch January 21, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants