Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: non-native ECC circuit APIs: followup #302

Merged
merged 12 commits into from
Jun 14, 2023
Merged

feat: non-native ECC circuit APIs: followup #302

merged 12 commits into from
Jun 14, 2023

Conversation

chancharles92
Copy link
Contributor

@chancharles92 chancharles92 commented Jun 6, 2023 •
edited
Loading

Description

closes: #301

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@mrain mrain changed the title Non-native ECC circuit APIs: followup feat: non-native ECC circuit APIs: followup Jun 13, 2023
@chancharles92 chancharles92 mentioned this pull request Jun 14, 2023
Closed
2 tasks
@chancharles92
Copy link
Contributor Author

Move followup todos to issue #320

@chancharles92 chancharles92 marked this pull request as ready for review June 14, 2023 20:54
@chancharles92 chancharles92 requested a review from mrain June 14, 2023 20:54
mrain
mrain previously approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@mrain mrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrain mrain self-requested a review June 14, 2023 21:09
@chancharles92 chancharles92 merged commit 86f221f into main Jun 14, 2023
@chancharles92 chancharles92 deleted the ecc-non-native-binyi branch June 14, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrain mrain mrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Followup APIs needed from ECC non-native circuit
2 participants
@chancharles92 @mrain