Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Snafu for TaggedBlobError. #30

Merged
merged 2 commits into from
Feb 26, 2022
Merged

Derive Snafu for TaggedBlobError. #30

merged 2 commits into from
Feb 26, 2022

Conversation

jbearer
Copy link
Member

@jbearer jbearer commented Feb 25, 2022

This implements Display, which allows us to take TaggedBlob types on the command line using structopt.

@jbearer
Derive Snafu for TaggedBlobError.
18b2548 
This implements Display, which allows us to take TaggedBlob types
on the command line using structopt.
@jbearer jbearer self-assigned this Feb 25, 2022
alxiong
alxiong approved these changes Feb 26, 2022
View reviewed changes
Copy link
Contributor

@alxiong alxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alxiong alxiong merged commit be58b5d into main Feb 26, 2022
@alxiong alxiong deleted the jeb-snafu branch February 26, 2022 08:57
@alxiong
Copy link
Contributor

alxiong commented Jul 26, 2022

@jbearer Can we just manually implement Display without depending on Snafu? That would be sufficient for the downsteam?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxiong alxiong alxiong approved these changes

@zhenfeizhang zhenfeizhang Awaiting requested review from zhenfeizhang

Assignees

@jbearer jbearer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbearer @alxiong