Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial WASM Support #254

Merged
merged 13 commits into from
May 13, 2023
Merged

Initial WASM Support #254

merged 13 commits into from
May 13, 2023

Conversation

alxiong
Copy link
Contributor

@alxiong alxiong commented May 11, 2023

Description

Closes: #252
Partially address: #248


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

.github/workflows/build.yml Outdated Show resolved Hide resolved
@@ -36,7 +36,7 @@ mod bench {
10
};

let poly = Arc::new(DenseMultilinearExtension::rand(nv, &mut rng));
let poly = Rc::new(DenseMultilinearExtension::rand(nv, &mut rng));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single threaded benchmarks only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed back in d1e8c3b

@alxiong alxiong requested a review from jbearer May 11, 2023 17:23
@alxiong alxiong requested a review from nyospe May 12, 2023 15:06
Copy link

@nyospe nyospe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, LGTM now.

@alxiong alxiong merged commit 45328b8 into main May 13, 2023
@alxiong alxiong deleted the wasm branch May 13, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cross compilation to wasm32 for blst
3 participants