-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial WASM Support #254
Initial WASM Support #254
Conversation
primitives/benches/pcs.rs
Outdated
@@ -36,7 +36,7 @@ mod bench { | |||
10 | |||
}; | |||
|
|||
let poly = Arc::new(DenseMultilinearExtension::rand(nv, &mut rng)); | |||
let poly = Rc::new(DenseMultilinearExtension::rand(nv, &mut rng)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
single threaded benchmarks only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed back in d1e8c3b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, LGTM now.
Description
Closes: #252
Partially address: #248
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Wrote unit testsPending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer