-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vrf Audit #156
Conversation
test_canonical_serde_helper(sig); | ||
} | ||
|
||
// TODO: (alex) update this after upgrading to arkwork 0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaken this will need to be upgraded anyway, since e.g. the deserialize
method will have a new signature in 0.4.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah, that's exactly what I meant. CanonicalDeserialize
have 4 combinations of (un)compressed + (un)check. which makes more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TODO doesn't hurt though, it was just FYI.
Description
This PR fix issues raised in our self-audit on BLS implementations.
Major changes include:
Zeroizing::new(ikm)
internallykey_gen_v5
to allow generation of multiple keys using the sameikm
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer