Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.1.3 #149

Merged
merged 6 commits into from
Nov 30, 2022
Merged

Release 0.1.3 #149

merged 6 commits into from
Nov 30, 2022

Conversation

sveitser
Copy link
Contributor

@sveitser sveitser commented Nov 29, 2022 •
edited by alxiong
Loading

Closes #151

Update crypto box to prevent dependency resolution conflicts.

See zulip thread for issue that currently arises.

See: #107 for original PR with the change.

  • Add a release branch, since this diverges from main.
  • Build pushes and PRs to release branch.

sveitser and others added 2 commits November 29, 2022 11:51
@sveitser
Build release branches and PRs to release branches
c3b6806
@dependabot @alxiong @sveitser
Update crypto_box requirement from 0.7.1 to 0.8.1 (#107)
fbdac81 
* Update crypto_box requirement from 0.7.1 to 0.8.1

Updates the requirements on [crypto_box](https://github.com/RustCrypto/nacl-compat) to permit the latest version.
- [Release notes](https://github.com/RustCrypto/nacl-compat/releases)
- [Commits](RustCrypto/nacl-compat@crypto_box-v0.7.1...crypto_box-v0.8.1)

---
updated-dependencies:
- dependency-name: crypto_box
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* update with crypto_box new API

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Xiong <[email protected]>
@sveitser
Fix clippy errors
b4f4af6
@sveitser
Release 0.1.3
2d3dd52 
Update crypto box to prevent dependency resolution conflicts.

See: #107

- Add a release branch, since this diverges from main.
- Build pushes and PRs to release branch.
@sveitser
Copy link
Contributor Author

Hmm. There are actually a lot more clippy warnings. They don't show up locally because the dev env for this release is still using rust 1.56.1 which doesn't seem to have these lints. Not sure what's the best course of action.

@DieracDelta
Copy link

DieracDelta commented Nov 29, 2022 •
edited
Loading

This isn't intended as a long term solution, but rather a stop gap. Maybe we can explicitly ignore/disable the clippy lints that are being triggered for now?

@alxiong alxiong mentioned this pull request Nov 29, 2022
Closed
2 tasks
@alxiong
Copy link
Contributor

alxiong commented Nov 29, 2022 •
edited
Loading

@DieracDelta try to pin your local HotShot and Espresso to this branch, see if it compiles.
If no further issue, we can merge this, and I will tag a release tmr.

@alxiong
Copy link
Contributor

alxiong commented Nov 30, 2022 •
edited
Loading

Update: it seems jf-cap also needs to update, otherwise zeroize version still conflicts. Let me quickly fix that today.

UPDATE: realized that jf-cap depends on jellyfish and need to cascading bump. so merging this now!

@alxiong alxiong merged commit 06e5b4b into release-0.1 Nov 30, 2022
@alxiong alxiong deleted the release/0.1.3 branch November 30, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrain mrain Awaiting requested review from mrain

@DieracDelta DieracDelta Awaiting requested review from DieracDelta

@alxiong alxiong Awaiting requested review from alxiong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sveitser @DieracDelta @alxiong