-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sponge API refactor #146
Sponge API refactor #146
Conversation
Btw, it goes a little further than #50, in that it also uses the new |
@EspressoSystems/jellyfish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 👍 Rescue interface looks cleaner now.
There are a few questions left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the refactoring! being explicit about what we are using Rescue for is very good.
- IMO,
RescueSpongeCRHF
should beRescueSpongeCRH
or even simplerRescueCRH
Co-authored-by: Alex Xiong <[email protected]>
@EspressoSystems/jellyfish This should be ready for a (hopefully) final round of reviews! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. Could you add some lines in CHANGELOG.md
under PENDING section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This is a WIP.
The refactor defines new explicit types for CRHF and PRF which are sponges that internally use the Rescue
Permutation
, and as such is more aligned with the CAPE spec.By following the sponge API we are able to re-use code shared between the above two functionalities.
It should then be then easier to make the circuits more generic by also defining and implementing a trait like CryptographicSpongeVar, though we'd probably need to define our own due to a dependency on a R1CS
ConstraintSystem
.closes: #15
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer