Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some trait bound #105

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Fixing some trait bound #105

merged 2 commits into from
Aug 15, 2022

Conversation

alxiong
Copy link
Contributor

@alxiong alxiong commented Aug 15, 2022

Description

Major changes include:


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md (@zhenfeizhang I don't think we need to add this to changelog, WDYT?)
  • Re-reviewed Files changed in the GitHub PR explorer

@alxiong alxiong self-assigned this Aug 15, 2022
Copy link
Contributor

@zhenfeizhang zhenfeizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM. A question: why do we need CloneGate in the first place? Is it possible to simply remove impl<F: Field> Clone for Box<dyn Gate<F>>?

Copy link
Contributor

@mrain mrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alxiong
Copy link
Contributor Author

alxiong commented Aug 15, 2022

why do we need CloneGate in the first place? Is it possible to simply remove impl<F: Field> Clone for Box<dyn Gate>?

because of this. I was using the suggested answer there, until I saw the better option below (i.e dyn_clone crate)

@alxiong alxiong merged commit deb1408 into main Aug 15, 2022
@alxiong alxiong deleted the alex/bound-fix branch August 15, 2022 13:39
@zhenfeizhang
Copy link
Contributor

why do we need CloneGate in the first place? Is it possible to simply remove impl<F: Field> Clone for Box?

because of this. I was using the suggested answer there, until I saw the better option below (i.e dyn_clone crate)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants