add public keys into signature aggregation APIs (#238)

* refactor aggregate APIs * update changelog
EspressoSystems · Apr 18, 2023 · e8e4644 · e8e4644
1 parent 3967921
commit e8e4644
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,8 @@ and follow [semantic versioning](https://semver.org/) for our releases.
 
 ### Changed
 
+- [#238](https://github.com/EspressoSystems/jellyfish/pull/238) add public keys into signature aggregation APIs
+
 ### Removed
 
 ### Deprecated

diff --git a/primitives/src/signatures/bls_over_bn254.rs b/primitives/src/signatures/bls_over_bn254.rs
@@ -127,8 +127,10 @@ impl SignatureScheme for BLSOverBN254CurveSignatureScheme {
 
 impl AggregateableSignatureSchemes for BLSOverBN254CurveSignatureScheme {
     /// Aggregate multiple signatures into a single signature
+    /// Follow the instantiation from <https://www.ietf.org/archive/id/draft-irtf-cfrg-bls-signature-05.html#name-aggregate>
     fn aggregate(
         _pp: &Self::PublicParameter,
+        _vks: &[Self::VerificationKey],
         sigs: &[Self::Signature],
     ) -> Result<Self::Signature, PrimitivesError> {
         if sigs.is_empty() {
@@ -144,6 +146,7 @@ impl AggregateableSignatureSchemes for BLSOverBN254CurveSignatureScheme {
     /// Verify an aggregate signature w.r.t. a list of messages and public keys.
     /// It is user's responsibility to ensure that the public keys are
     /// validated.
+    /// Follow the instantiation from <https://www.ietf.org/archive/id/draft-irtf-cfrg-bls-signature-05.html#name-coreaggregateverify>
     fn aggregate_verify<M: AsRef<[Self::MessageUnit]>>(
         _pp: &Self::PublicParameter,
         vks: &[Self::VerificationKey],
@@ -194,6 +197,7 @@ impl AggregateableSignatureSchemes for BLSOverBN254CurveSignatureScheme {
     /// Verify a multisignature w.r.t. a single message and a list of public
     /// keys. It is user's responsibility to ensure that the public keys are
     /// validated.
+    /// Follow the instantiation from <https://www.ietf.org/archive/id/draft-irtf-cfrg-bls-signature-05.html#name-fastaggregateverify>
     fn multi_sig_verify(
         pp: &Self::PublicParameter,
         vks: &[Self::VerificationKey],

diff --git a/primitives/src/signatures/mod.rs b/primitives/src/signatures/mod.rs
@@ -94,8 +94,11 @@ pub trait SignatureScheme {
 /// TODO: generic over hash functions
 pub trait AggregateableSignatureSchemes: SignatureScheme {
     /// Aggregate multiple signatures into a single signature
+    /// The list of public keys is also in the input as some aggregate signature
+    /// schemes might also use pks for aggregation
     fn aggregate(
         pp: &Self::PublicParameter,
+        vks: &[Self::VerificationKey],
         sigs: &[Self::Signature],
     ) -> Result<Self::Signature, PrimitivesError>;
 
@@ -158,8 +161,8 @@ mod tests {
             partial_sigs.push(partial_sig);
         }
         // happy paths
-        let agg_sig = S::aggregate(&parameters, &sigs).unwrap();
-        let multi_sig = S::aggregate(&parameters, &partial_sigs).unwrap();
+        let agg_sig = S::aggregate(&parameters, &pks, &sigs).unwrap();
+        let multi_sig = S::aggregate(&parameters, &pks, &partial_sigs).unwrap();
         assert!(S::aggregate_verify(&parameters, &pks, messages, &agg_sig).is_ok());
         assert!(S::multi_sig_verify(&parameters, &pks, message_for_msig, &multi_sig).is_ok());
         // wrong messages length