This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Add VidDisperseShare data type
#28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to drop the previous PR because I've merged main into it too fast. HotShot is not yet ready for hotshot-types main branch. I'm also not sure what is the preferred way to handle those lint errors. One is related to my change (complex type) but the other two are unrelated. I can put those enum variants in the |
bfish713
approved these changes
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #1696 in HotShot
This PR:
Adds a new struct
VidDisperseShare.VidDisperseShareconsists of only one VID share and keeps information about its dedicated recipient.VidDisperseShareis sent as a direct message to its recipient only.Consensus's fieldvid_sharesis now aBTreeMappof views -> (HashMapof recipient key ->ProposalofVidDisperseShare). This way a VID share can be found by view number and VID share's recipient key.This PR does not:
Key places to review:
Changes in src/consensus.rs
Changes in src/data.rs
How to test this PR:
All the HotShot tests should pass.