Update hotshot #279
Merged
Update hotshot #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous pinned commit required seemed to have missing packages which required a lot of compilation.
sveitser
force-pushed
the
feat/hotshot-update
branch
from
e157ff2 to
afb6195
Compare
- Comment out a few things to compile further.
- Going through compilation errors with `--all-features`.
Use `Commitment<Header>` as the block commitment. Replace mock types with the mocks from HotShot. Fill in some todo!()s
Minimal metrics-only data source for status API
This requires some incidental changes to tests, due to the fact that the block height is no 1 from the instant of initialization.
|
@jbearer LGTM. I can't approve because I opened the PR. |
jbearer
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close EspressoSystems/espresso-sequencer#784