-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor comments.
OTOH, do we also want to create a PR in Jellyfish for below?
https://github.com/EspressoSystems/jellyfish/tree/fix/signature-scheme-serde
@philippecamacho So later when we implement SNARK-based QC, we are going to put the hash_digest into |
… and QCVerifierParams.
…e message before hashing it.
You mean the stake table digest? |
Yes, the PR has been created: EspressoSystems/jellyfish#271 |
Yes |
Ok then yes, it make sense to have the stake table digest be a public input of the snark circuit. |
Closes #31. Some remarks:
QCParams.stake_table_digest
has been removed because (1) it is not used and (2) it creates complications for serde with Jellyfish (Schnorr signature).