Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Feat/t31 qc serde #39

Merged
merged 10 commits into from
May 25, 2023
Merged

Feat/t31 qc serde #39

merged 10 commits into from
May 25, 2023

Conversation

philippecamacho
Copy link
Contributor

Closes #31. Some remarks:

Copy link
Contributor

@chancharles92 chancharles92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments.
OTOH, do we also want to create a PR in Jellyfish for below?
https://github.com/EspressoSystems/jellyfish/tree/fix/signature-scheme-serde

src/quorum_certificate.rs Outdated Show resolved Hide resolved
src/quorum_certificate.rs Outdated Show resolved Hide resolved
src/quorum_certificate.rs Outdated Show resolved Hide resolved
@chancharles92
Copy link
Contributor

@philippecamacho So later when we implement SNARK-based QC, we are going to put the hash_digest into Proof correct?

@philippecamacho
Copy link
Contributor Author

@philippecamacho So later when we implement SNARK-based QC, we are going to put the hash_digest into Proof correct?

You mean the stake table digest?

@philippecamacho
Copy link
Contributor Author

LGTM, some minor comments. OTOH, do we also want to create a PR in Jellyfish for below? https://github.com/EspressoSystems/jellyfish/tree/fix/signature-scheme-serde

Yes, the PR has been created: EspressoSystems/jellyfish#271

@chancharles92
Copy link
Contributor

@philippecamacho So later when we implement SNARK-based QC, we are going to put the hash_digest into Proof correct?

You mean the stake table digest?

Yes

@philippecamacho
Copy link
Contributor Author

@philippecamacho So later when we implement SNARK-based QC, we are going to put the hash_digest into Proof correct?

You mean the stake table digest?

Yes

Ok then yes, it make sense to have the stake table digest be a public input of the snark circuit.

@philippecamacho philippecamacho merged commit 6fcff3d into main May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Serialization/Deserialization for QC
2 participants