This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
Do not call payload.num_transactions()
#211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR just substitutes a call to
payload.num_transactions()withself.tx_queue.len()which gives the same results.payload.num_transactions()looks deceptively harmless but the implementation in Payload is very cpu heavy.I see big performance improvement with just this change.
This PR does not:
Unfortunately does not fix the current builder issues. Builder works visibly faster but is still very cpu-heavy and the sequencer times out waiting for the blocks.
Key places to review: