remove generic from stake table #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabdulbasit
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
sveitser
reviewed
Dec 10, 2024
types/src/v0/impls/stake_table.rs
Outdated
| .iter() | ||
| .map(|entry| (TYPES::SignatureKey::public_key(entry), entry.clone())) | ||
| .collect(); | ||
| let indexed_stake_table: BTreeMap<PubKey, SeqStakeTableEntry> = members |
There was a problem hiding this comment.
I think for all containers here we can do leave the item type(s) as _ now.
sveitser
reviewed
Dec 10, 2024
types/src/v0/impls/stake_table.rs
Outdated
| NonZeroU64::new(max( | ||
| (self.stake_table.len() as u64 * 9) / 10, | ||
| ((self.stake_table.len() as u64 * 2) / 3) + 1, | ||
| )) | ||
| .unwrap() | ||
| } | ||
| } | ||
|
|
||
| type Epoch = <SeqTypes as NodeType>::Epoch; |
sveitser
approved these changes
Dec 10, 2024
imabdulbasit
merged commit f1b2799
into
tb/pos/fetch-stake-table2
14 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.