Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove cruft #2300

Merged
merged 4 commits into from
Nov 19, 2024
Merged

ci: remove cruft #2300

merged 4 commits into from
Nov 19, 2024

Conversation

sveitser
Copy link
Collaborator

@sveitser sveitser commented Nov 19, 2024

  • Only checkout submodules when neeeded (building contracts)
  • Only install forge when needed (build contracts, docs), edit: anvil is needed to run the tests
  • Nextest is already installed on ubuntu-latest (edit: I have seen it installed, however things failed here when I removed it)

Some jobs might fail, will fix them after CI runs.

Closes #2289

- Only checkout submodules when neeede (building contracts)
- Only install forge when needed (build contracts, docs)
- Nextest is already installed on ubuntu-latest
@@ -1,34 +0,0 @@
name: test
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not used probably created by foundry when initializing the project.

@sveitser sveitser marked this pull request as ready for review November 19, 2024 14:57
Copy link
Contributor

@tbro tbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sveitser sveitser merged commit 4c8a935 into main Nov 19, 2024
19 checks passed
@sveitser sveitser deleted the ma/ci-remove-unnecessary-submodules branch November 19, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: remove submodule checkout for jobs that don't need them
2 participants