-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch stake table #2237
Closed
Closed
Fetch stake table #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbro
force-pushed
the
tb/pos/fetch-stake-table
branch
4 times, most recently
from
October 31, 2024 21:23
4e71be7
to
c9c334d
Compare
tbro
force-pushed
the
tb/pos/fetch-stake-table
branch
from
November 1, 2024 23:05
c9c334d
to
5448181
Compare
Adds the ability to fetch stake table from l1. It adds StakeCommittee type which replaces StaticCommittee. This new type implements Membershp trait, holds L1Client and fn update_stake_table to update Self.stake_table. In this way, hotshot will be able to obtain StakeTable via SystemContextHandle.members.
tbro
force-pushed
the
tb/pos/fetch-stake-table
branch
from
November 4, 2024 20:26
5448181
to
6ce37b5
Compare
tbro
commented
Nov 5, 2024
&self, | ||
_block: u64, | ||
_address: Address, | ||
) -> Vec<<TYPES::SignatureKey as SignatureKey>::StakeTableEntry> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link
Superseded by #2361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EspressoSystems/HotShot#3726
This PR
Adds the ability to fetch stake table from l1. It adds
StakeCommittee
type which replacesStaticCommittee
. This new type implements Membershp trait, holds L1Client andfn update_stake_table
to updateSelf.stake_table
. In this way, hotshot will be able to obtainStakeTable
viaSystemContextHandle.members
.TODO