[WEEKLY RELEASE] HotShot - rc-0.5.78 #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenkeyao
reviewed
Oct 17, 2024
shenkeyao
approved these changes
Oct 17, 2024
ss-es
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
…sequencer into bump/rc-0.5.78
jbearer
requested changes
Oct 21, 2024
| @@ -161,7 +151,7 @@ async fn run<V: Versions>( | |||
| opt.hotshot_event_streaming_url, | |||
| builder_server_url, | |||
| api_response_timeout_duration, | |||
| buffer_view_num_count, | |||
| ChainConfig::default().max_block_size.into(), | |||
There was a problem hiding this comment.
Uhh @shenkeyao why are we defaulting this? This should come from the actual chain config, e.g. instance_state.chain_config.max_block_size
There was a problem hiding this comment.
Good catch, updated! Using instance_state.chain_config also allows us to simplify the function by removing this argument, since we already have instance_state as an arg.
jbearer
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.