[WEEKLY RELEASE] HotShot 0.5.74 #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxiong
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
|
should we also try to replace |
alxiong
commented
Sep 7, 2024
| @@ -467,6 +467,7 @@ pub trait SequencerPersistence: Sized + Send + Sync + 'static { | |||
| state, | |||
| validated_state, | |||
| view, | |||
| highest_voted_view, | |||
There was a problem hiding this comment.
Can we change v0 struct like this? @sveitser
We need this to placate the tests, but not sure if we should edit the v0
There was a problem hiding this comment.
I think its fine to change it since we don't define it at sequencer side and serialize it.
imabdulbasit
reviewed
Sep 9, 2024
Ayiga
reviewed
Sep 9, 2024
yes, we decided to commit them. #1068 (comment) |
alxiong
changed the title
alxiong
merged commit 80b57e0
into
1938-simplify-light-client-contract-create-genesis-state-struct-and-remove-states-mapping
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Another attempt to update hotshot version to
rc-0.5.74, aims to supercede #1988The plan is to merge into
1938-xxxbranch and merge intomain, this commit would still appear in themainhistory thus easy to locate.