Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recipe for clippy to justfile #1514

Merged
merged 2 commits into from
May 29, 2024
Merged

add recipe for clippy to justfile #1514

merged 2 commits into from
May 29, 2024

Conversation

imabdulbasit
Copy link
Contributor

This PR adds a clippy recipe to the Justfile.
Usage: just clippy.

@imabdulbasit imabdulbasit force-pushed the abdul/clippy-recipe branch from 6a46f6a to cd94aef Compare May 29, 2024 03:17
@imabdulbasit imabdulbasit enabled auto-merge May 29, 2024 03:19
@sveitser
Copy link
Collaborator

This is fine but I think we shouldn't duplicate the clippy command we have in flake.nix yet another time. It's already duplicated in the CI job. We can replace the pre-commit hook inside flake.nix with just clippy in addition to the change in this PR.

If you're using the nix dev env you can also run pre-commit run cargo-clippy --all-files to run the pre-commit hook. Similarly for the other hooks.

@sveitser sveitser disabled auto-merge May 29, 2024 07:52
@imabdulbasit imabdulbasit merged commit 2316c78 into main May 29, 2024
13 checks passed
@imabdulbasit imabdulbasit deleted the abdul/clippy-recipe branch May 29, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants