Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add u32 and u16 #45

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Add u32 and u16 #45

merged 8 commits into from
Jan 16, 2024

Conversation

ss-es
Copy link
Contributor

@ss-es ss-es commented Jan 12, 2024

Needed to build a commitment with some u32/u16 fields

@ss-es ss-es enabled auto-merge January 12, 2024 20:21
@ss-es ss-es disabled auto-merge January 12, 2024 20:28
@ss-es
Copy link
Contributor Author

ss-es commented Jan 12, 2024

Had to allow unused_imports because clippy would complain that TryInto was unusued, but building in CI would fail without TryInto. Also did some extra cleanup for clippy lints to pass.

@ss-es ss-es enabled auto-merge (squash) January 12, 2024 20:38
@ss-es ss-es requested a review from jbearer January 12, 2024 20:38
@ss-es ss-es changed the title Add u32 Add u32 and u16 Jan 15, 2024
@ss-es ss-es requested review from rob-maron and removed request for jbearer January 15, 2024 23:06
@ss-es ss-es merged commit dd9f16e into main Jan 16, 2024
2 checks passed
@ss-es ss-es deleted the ss-es/u32 branch January 16, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants