Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Use nix based docker base image #730

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Conversation

sveitser
Copy link
Contributor

@sveitser sveitser commented Mar 11, 2022

Motivation

  1. No need for patchelf. Base image inputs are tracked with nix.
  2. Make it possible to build the image locally. Should make it easier to put together the remaining images we need.

@sveitser
Copy link
Contributor Author

sveitser commented Mar 11, 2022

Building the base image works on the CI but the final "Build and Push Docker" step fails. I think it's because it's trying to fetch metadata about the base image from dockerhub and that image doesn't exist.

https://github.com/EspressoSystems/cape/runs/5511464159?check_suite_focus=true

@sveitser
Copy link
Contributor Author

Possibly relevant: docker/build-push-action#425 (comment)

@sveitser
Copy link
Contributor Author

It does seem to build successfully with the docker driver.

.github/workflows/build.yml Outdated Show resolved Hide resolved
@sveitser sveitser marked this pull request as ready for review March 11, 2022 15:09
@Ancient123
Copy link
Member

Discussed with @sveitser via chat. Approved.

.github/workflows/build.yml Outdated Show resolved Hide resolved
- Use docker driver to load nix base image
@sveitser sveitser force-pushed the feat/t724-docker-images-for-demo branch from bdb98a2 to f346a31 Compare March 14, 2022 21:28
@sveitser sveitser requested a review from Ancient123 March 15, 2022 15:41
@sveitser sveitser merged commit e453f09 into main Mar 15, 2022
@sveitser sveitser deleted the feat/t724-docker-images-for-demo branch March 15, 2022 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants