Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Fix CODEOWNERS file #1231

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Fix CODEOWNERS file #1231

merged 2 commits into from
Nov 3, 2022

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Nov 3, 2022

I noticed that the file wasn't working as expected as all the usernames were missing the leading @ sign.

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2022

CLA assistant check
All committers have signed the CLA.

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@sveitser
Copy link
Contributor

sveitser commented Nov 3, 2022

Thanks. Unfortunately the file is also very out of date. I made some suggestions.

@kevinji
Copy link
Contributor Author

kevinji commented Nov 3, 2022

Just pushed an updated file.

@sveitser sveitser enabled auto-merge November 3, 2022 18:07
@sveitser sveitser self-requested a review November 3, 2022 18:07
Copy link
Contributor

@sveitser sveitser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sveitser sveitser disabled auto-merge November 3, 2022 18:08
@sveitser sveitser enabled auto-merge (squash) November 3, 2022 18:09
@sveitser sveitser merged commit fcc45d7 into EspressoSystems:main Nov 3, 2022
@kevinji kevinji deleted the patch-1 branch November 3, 2022 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants