This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Arbitrum tests #1230
Merged
Arbitrum tests #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Specify manual gas limit where estimated value leads to transaction running out of gas. - Add some `.ensure_mined()` calls. - Replace some unwraps with `?`.
- Specify manual gas limit where transactions run out of gas.
Fixes `cape::events::tests::test_fetch_cape_memos_from_event`
If `CAPE_WEB3_PROVIDER_URL` is `get_funded_client()` returns the same client each time its called. Use a `call` instead of a `send` to avoid requiring a funded client. This still ensures that the call fails for the right reason (the function was called from the wrong account) because we match against the revert reason.
We previously set the limit manually but this is tricky because gas cost is different on arbitrum. By adding the 10M to the estimate instead it should work for both L1's and arbitrum. Remove the test that tests if the extra gas has effect. The test would be a bit involved to rewrite right now because we can't set a too low gas limit directly anymore.
|
The test |
sveitser
commented
Nov 3, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
bin/run-tests-arbitrumscript to run tests against arbitrum. This re-uses the libraries to save some gas and time.