This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Use EIP1559 transactions #1228
Merged
Use EIP1559 transactions #1228
+83
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason why we should not fix the tests, merge to main and deploy the changes to the Goerli services? |
|
The only reason would be that it's not enough of a priority to make this change. |
- Specify manual gas limit where estimated value leads to transaction running out of gas. - Add some `.ensure_mined()` calls. - Replace some unwraps with `?`.
- Specify manual gas limit where transactions run out of gas.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are failing. They can likely be fixed by manually specifying a high enough gas limit.