This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
faucet: remove key if pubkey can't be looked up #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
reviewed
Jul 18, 2022
faucet/src/faucet.rs
Outdated
| // If we failed, mark the request as failed in the queue so it can be retried | ||
| // later. | ||
| state.queue.fail(pub_key).await; | ||
| if let seahorse::WalletError::PubkeyNotFound { address } = err { |
There was a problem hiding this comment.
Also CapeWalletError::PubKeyNotFound should work
faucet/src/faucet.rs
Outdated
| @@ -525,23 +525,6 @@ async fn request_fee_assets( | |||
| ) -> Result<tide::Response, tide::Error> { | |||
| check_service_available(req.state()).await?; | |||
| let pub_key: UserPubKey = net::server::request_body(&mut req).await?; | |||
|
|
|||
There was a problem hiding this comment.
Should we keep this so that in the future, if the user submits a request for a key that is not in the address book, they get an error response instead of an ok response that later fails silently?
This re-applies commit fe37d0c
jbearer
approved these changes
Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
Also need to tag a seahorse release and reference it here.