This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Eqs remove unbounded queries #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return at most 100 events.
The endpoint is unused, remove it.
|
The slither error is strange and not related to this PR. The rev we fetch does exist. I don't know why |
Instead of resetting the backoff to the minimum, reduce it by a factor of 2 after succesfully fetching new events.
|
All the tests pass on my machine @sveitser. |
This reverts commit 88794ce. Let's go with the change that we all agree on first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have issues running the tests locally
backend::test::test_transferfails like inbackend::test::test_anonymous_erc20_transferfails withresponse body fails to deserialize#1179faucet::test::test_faucet_transfershows the same errors (relayer error: response body fails to deserialize: io error: unexpected end of file) and runs forever.Close #1190.