Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump jf-signature crate to v0.2.0 #3862

Merged
merged 4 commits into from
Nov 7, 2024
Merged

chore(deps): bump jf-signature crate to v0.2.0 #3862

merged 4 commits into from
Nov 7, 2024

Conversation

mrain
Copy link
Contributor

@mrain mrain commented Nov 6, 2024

Closes #<ISSUE_NUMBER>

This PR:

Bump jf-signature crate to v0.2.0 that prevents you from unnoticeably doing something bad with the private keys.
Thus every struct that contains a private signature key type cannot have a derived serde::Serialize. So I moved ValidatorConfig out of the HotShotConfig.

This PR does not:

There's still an indirect deps to jf-signatire v0.1.0 through PushCDN 0.4.7. It'll be removed after upgrading to PushCDN >0.5.4

Key places to review:

Copy link
Contributor

@ss-es ss-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@mrain mrain merged commit 61400f5 into main Nov 7, 2024
25 checks passed
@mrain mrain deleted the cl/private_keys branch November 7, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants