Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert crates/types/src/vid.rs to 01ea0ab9 #3813

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Revert crates/types/src/vid.rs to 01ea0ab9 #3813

merged 5 commits into from
Oct 28, 2024

Conversation

ggutoski
Copy link
Contributor

Closes #3812

This PR:

completely revert all changes to crates/types/src/vid.rs introduced in 36ac48d

This PR does not:

Key places to review:

Copy link
Contributor

@dailinsubjam dailinsubjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although worth waiting for another approval and CI results.

@ggutoski ggutoski merged commit 5d9ed74 into main Oct 28, 2024
23 of 24 checks passed
@ggutoski ggutoski deleted the gg/3812 branch October 28, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[<TECH_DEBT>] - Revert newtype wrapper for VidCommitment
4 participants