Add Error type to Membership trait
#3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
We are making the implementation of the
Membershiptrait for proof-of-stake the responsibility of the sequencer.This PR allows the
Membershiptrait to be implemented with a custom error type (vialookup_leader), rather than forcing the sequencer to useanyhowor our own internal error type.This PR does not:
The goal was to make a minimal change here (i.e. not have to touch any code in
task-impls), so I added a new method with a different name rather than changingleaderKey places to review:
Is there a better naming convention?