Add anyhow replacement #3777
Closed
Add anyhow replacement #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Adds a replacement for
anyhowthat logs like tracing.Currently, the crate propagates an error to the top level.
ensure!andbail!macro also log the error in-place at the given level, allowing for instrumentation.This is used in #3738, to allow some more tasks to return a
Result<()>.This PR does not:
Key places to review:
I think the implementation is relatively flexible and we can adjust to log centrally and/or log at the
ensure!statements. I think the main thing to do would be to take a quick look at #3738 and see that the usage there is reasonable