push task_state as QuorumProposalRecv task state into helper function… #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, rename consensus2
ss-es
approved these changes
Oct 15, 2024
| @@ -63,7 +63,7 @@ pub struct TestView { | |||
| pub da_certificate: DaCertificate<TestTypes>, | |||
| pub transactions: Vec<TestTransaction>, | |||
| upgrade_data: Option<UpgradeProposalData<TestTypes>>, | |||
| pub formed_upgrade_certificate: Option<UpgradeCertificate<TestTypes>>, | |||
| formed_upgrade_certificate: Option<UpgradeCertificate<TestTypes>>, | |||
There was a problem hiding this comment.
was this intentional? (not that it matters either way)
There was a problem hiding this comment.
yeah this reverted us making that pub when we were playing around with the tests that ended up getting removed by the previous PR
bfish713
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s, rename consensus2
Closes #3640
This PR:
Finishes the rest of #3640 by pushing task_state into helper functions instead of copying the component parts; this is no longer necessary as consensus has been removed in lieu of consensus2. Also renames consensus2->consensus, and cleans up some other bits of code.
This PR does not:
Key places to review:
In particular, check over the functions update_view and handle_quorum_proposal_recv. In at least one case, I was worried that a local copy of a mutable reference var was being copied locally to allow changing the pointed-to value while being able to access the previous value. I believe I got this correct but want an extra set of eyes to check it.