Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easy] Remove TYPES from Libp2pNetwork::from_config #3750

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[Easy] Remove TYPES from Libp2pNetwork::from_config #3750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/examples/infra/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@ where
derive_libp2p_multiaddr(&bind_address).expect("failed to derive bind address");

// Create the Libp2p network
let libp2p_network = Libp2pNetwork::from_config::<TYPES>(
let libp2p_network = Libp2pNetwork::from_config(
config.clone(),
GossipConfig::default(),
bind_address,
Expand Down
2 changes: 1 addition & 1 deletion crates/hotshot/src/traits/networking/libp2p_network.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ impl<K: SignatureKey + 'static> Libp2pNetwork<K> {
///
/// # Panics
/// If we are unable to calculate the replication factor
pub async fn from_config<TYPES: NodeType>(
pub async fn from_config(
mut config: NetworkConfig<K>,
gossip_config: GossipConfig,
bind_address: Multiaddr,
Expand Down