Remove data request-response code. #3747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #3740 which removes the remaining bits of data request-response code.
ss-es
reviewed
Oct 10, 2024
| @@ -160,8 +139,6 @@ pub enum NetworkEventInternal { | |||
| GossipEvent(Box<GossipEvent>), | |||
| /// a direct message event | |||
| DMEvent(libp2p::request_response::Event<Vec<u8>, Vec<u8>>), | |||
| /// a request response event | |||
| RequestResponseEvent(libp2p::request_response::Event<Request, Response>), | |||
There was a problem hiding this comment.
I know the enum doesn't derive Serialize, but I'm a bit worried that removing variants might be a breaking libp2p change somehow. Does this definitely not get serialized somehow at any point?
There was a problem hiding this comment.
Good question, but no it should not be. These events should be events that are created from messages we receive. Also libp2p should be good at handling nodes running different protocols sets of protocols (as long as each protocol they are both running match)
bfish713
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3740 which removes the remaining bits of data request-response code.