Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust some log levels #3737

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Adjust some log levels #3737

merged 4 commits into from
Oct 11, 2024

Conversation

rob-maron
Copy link
Collaborator

Changes log levels for some logs to be more accurate.

@rob-maron rob-maron requested a review from bfish713 as a code owner October 7, 2024 19:12
bfish713
bfish713 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@bfish713 bfish713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this clearly an improvement and I trust your judgement to change some log levels base on my comments

crates/libp2p-networking/src/network/behaviours/dht/mod.rs Outdated Show resolved Hide resolved
crates/libp2p-networking/src/network/behaviours/dht/mod.rs Show resolved Hide resolved
crates/libp2p-networking/src/network/behaviours/dht/mod.rs Outdated Show resolved Hide resolved
crates/task-impls/src/transactions.rs Outdated Show resolved Hide resolved
@rob-maron rob-maron merged commit c7a074d into main Oct 11, 2024
28 checks passed
@rob-maron rob-maron deleted the rm/adjust-log-levels branch October 11, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfish713 bfish713 bfish713 approved these changes

Assignees

@jparr721 jparr721

@lukeiannucci lukeiannucci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rob-maron @bfish713 @jparr721 @lukeiannucci