Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break task loops when channel closes #3709

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Break task loops when channel closes #3709

merged 1 commit into from
Sep 27, 2024

Conversation

ss-es
Copy link
Contributor

@ss-es ss-es commented Sep 27, 2024

This PR:

Breaks task loops when the channel closes in a few places

This PR does not:

I don't know if this necessarily fixes anything, but I think it makes the behaviour more correct

Key places to review:

@ss-es ss-es merged commit b8e76a0 into main Sep 27, 2024
37 checks passed
@ss-es ss-es deleted the ss/task-loop branch September 27, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants