New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a scenario where we were unable to manually start the orchestrator #3707

Merged

ss-es merged 1 commit into main from ss/orchestrator-fix-force-start

Sep 27, 2024

Contributor

ss-es commented Sep 27, 2024

We no longer disable manual starting after peer configs are distributed -- I don't think this added any real safety, but please leave a comment if I'm missing something.
We now actually set self.start when manually starting.


          fix orchestrator manual start

fb9f647

ss-es requested a review from bfish713 as a code owner

September 27, 2024 16:41

github-actions bot assigned shenkeyao and rob-maron

rob-maron approved these changes

View reviewed changes

ss-es merged commit 6cb45b8 into main

35 of 37 checks passed

ss-es deleted the ss/orchestrator-fix-force-start branch

September 27, 2024 17:46

rob-maron pushed a commit that referenced this pull request


          fix orchestrator manual start (#3707)

553af06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet