Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic-array should not be an explicit dependency #3696

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Generic-array should not be an explicit dependency #3696

merged 1 commit into from
Sep 23, 2024

Conversation

jparr721
Copy link
Contributor

Closes #<ISSUE_NUMBER>

This PR:

From the ticket:

Currently generic-array is an explicit direct dependency. All our use of generic-array is inherited from upstream RustCrypto crates such as blake3, sha3, digest, etc. Thus, the version of generic-array that we use should be whatever's used by these upstream crates. Thus, we should not list it as an explicit direct dependency.

Unfortunately, we need serde for generic-array and I don't know how to get it without listing generic-array as an explicit dependency. This is an insidious hack because it means that we must take care to always keep the version of generic-array we list in Cargo.toml consistent with whatever's used upstream.

This PR removes the generic-array dependency and instead gets it from digest which re-exports it.

This PR does not:

Key places to review:

Copy link
Contributor

@ggutoski ggutoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like there's a CI failure to resolve but I'm happy.

@jparr721 jparr721 merged commit 66f69e4 into main Sep 23, 2024
34 of 36 checks passed
@jparr721 jparr721 deleted the jp/1850 branch September 23, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants