Store upgrade certificate on decide and load on restart #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Should we retry the tests or something is really wrong? |
Running the failed tests again! I'm not particularly worried since they were different tests, and one of them was fixed in a separate PR (lowering the nonempty block threshold from 90% to 80%). The other one was a failure that I've seen on a few PRs, but since only the tokio dependency-tasks version failed I think it's just a timing issue |
lukaszrzasik
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Storagewhich the sequencer will be required to implement, allowing us to store upgrade certificates persistently through restarts.HotShotInitializer, which we will then load into consensus (if it is valid for our version of HotShot).This PR does not:
Key places to review: