Light client contract related changes #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 998dd79.
…en removed from the light client state
…he light client state
…ems/HotShot into lc-contract-updates
philippecamacho
changed the title
bfish713
approved these changes
Sep 6, 2024
jparr721
requested changes
Sep 6, 2024
Comment on lines
+249
to
+255
| self.0[5] | ||
| } | ||
|
|
||
| /// Return the threshold | ||
| #[must_use] | ||
| pub fn threshold(&self) -> F { | ||
| self.0[6] |
There was a problem hiding this comment.
All of these magic numbers are kind of tricky to reason about, can we just use a named struct?
There was a problem hiding this comment.
@alxiong @alysiahuggins do you remember if there is any particular reason why we don't use a named struct?
There was a problem hiding this comment.
this is the decision made by @mrain and i recall the public input right now is simple enough to keep track of?
i also personally prefer a named struct, less error prone.
but i tried to make minimal changes for this task, so kept the legacy way. Can update in the future as tech debt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of EspressoSystems/espresso-sequencer#1938
This PR:
The purpose of this PR is to update the GenericLightClientState struct (removing 4 fields) and introduce a new struct
GenericStakeTableStateto represent the stake table state (which is fixed). These changes are required to account for a refactoring of the Light Client contract which purpose is to remove all logic related to epochs. See EspressoSystems/espresso-sequencer#1938 for more context.Key places to review:
Only
crates/types/src/light_client.rsas other changes are due to runningcargo fmt.As usual (see README.md)