[TECH DEBT] Refactor memberships, remove non-staked nodes

[rob-maron]

This PR:

Refactors memberships to:

• Provide a better API
• Be more verbose (particularly when it comes to the quorum leader == DA leader hack we are doing)
• Remove the presence of non_staked nodes

It also removes non-staked node support from HotShot as a whole. We don't use the permissioned builder anymore, so it is increasing complexity on HS and the sequencer

Why do we need these changes?

While removing support for non-staked nodes, I remembered a few issues we had with memberships in the past; the primary one being that they are easy to get wrong. One time in the sequencer we constructed the DA membership with DA nodes (as would make sense), but this lead to an issue where DA votes were going to the wrong leaders. This makes things much more verbose

[jparr721]

couple of things

[bfish713]

Since you are already in here I want to pose some questions, why do we even have a DA membership at all? Why do we even have a DA leader concept at all, the leader is just the leader of a view. For DA even we theoretically could just send votes to whoever sent the proposal regardless of view/leadership. So can we just combine the memberships to just be 1 singular membership that is used everywhere and a DA committee is just a part of it

[rob-maron]

Since you are already in here I want to pose some questions, why do we even have a DA membership at all? Why do we even have a DA leader concept at all, the leader is just the leader of a view. For DA even we theoretically could just send votes to whoever sent the proposal regardless of view/leadership. So can we just combine the memberships to just be 1 singular membership that is used everywhere and a DA committee is just a part of it

Good question, I also thought this. I actually had gotten it to be almost removed in this PR, but didn't want to touch voting logic too much. I am 100% in favor of combining them though

EDIT: We have decided to keep them this way for now, making the necessary changes for the above later. It comes down to a high coupling with voting/membership types