-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lr/vote collector #3615
Merged
Merged
Lr/vote collector #3615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeiannucci
reviewed
Sep 3, 2024
lukeiannucci
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3564
This PR:
dishonest_voting
test that shows the original issue.NetworkEventTaskStateModifier
which can changeNetworkEventTaskState
's behaviour for testing purposes.handle_vote
to avoid code duplicationThis PR does not:
Does not change vote collecting for ViewSync tasks as these differ in the vote collecting logic. As far as I understand they are not susceptible to the original issue as well.
Key places to review:
Changes in the
crates/task-impls/src/vote_collection.rs
file. Especially the garbage collecting logic. I'm not sure about it.crates/task-impls/src/network.rs
file for the new testing wrapper.How to test this PR:
All CI tests should pass, including the new test.