[Byzantine testing] - View Lagging node #3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bfish713
requested changes
Aug 26, 2024
|
I'm not sure this does what it's supposed to do, my read of the logic is that is delays each event type by a number of views. So if we get a proposal for view 2 with a delay of 1 we'll actually broadcast the proposal for 1 but we wouldn't broadcast a DAC or VID share for view 1. With votes this is really awkward because it means at minimum the voting is delayed until our next leadership because that's the next time we'll get a vote |
lukeiannucci
force-pushed
the
li/byzantine-view-delay
branch
from
c8048c7 to
c374244
Compare
bfish713
reviewed
Aug 28, 2024
ss-es
reviewed
Aug 29, 2024
lukeiannucci
force-pushed
the
li/byzantine-view-delay
branch
from
64414de to
e8b5582
Compare
bfish713
reviewed
Sep 3, 2024
bfish713
approved these changes
Sep 3, 2024
lukeiannucci
force-pushed
the
li/byzantine-view-delay
branch
from
aa9bacf to
8ca07b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes (#3608)
This PR:
Adds a byzantine test where we have one node that is constantly behind by a a configurable set of views on the receive handle. When node receives an event for current view it will return an event that is cached.
Also this PR cleans up where we keep the Byzantine tests.
This PR does not:
Key places to review:
ViewDelaystruct and how it implementsEventTransformerStateto see the logic of how we handle delayed views. Also/crates/testing/src/byzantinethis is where i moved the byzantine logic to. Andcrates/testing/tests/tests_2is where byzantine tests are placed.