Add marketplace integration test #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfish713
reviewed
Aug 15, 2024
| @@ -349,7 +351,7 @@ impl< | |||
| } | |||
|
|
|||
| fn get_auction_results(&self) -> Option<TYPES::AuctionResult> { | |||
| unimplemented!() | |||
| Some(TYPES::AuctionResult { urls: vec![] }) | |||
There was a problem hiding this comment.
Can we make an issue to update this once the simple builder supports the marketplace?
There was a problem hiding this comment.
We should also enable transaction generation and checking that blocks contain transactions in tests when simple builder is updated, so that the test check the builder interaction as well.
QuentinI
reviewed
Aug 16, 2024
QuentinI
approved these changes
Aug 16, 2024
QuentinI
reviewed
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
consistency_taskto ensure that an upgrade certificate is actually attached to some leaf.test_success_marketplaceto test that an upgrade to the marketplace completes successfully and continues to run without any view failures.This PR does not:
Key places to review:
You can run the test on this branch with
RUST_LOG=hotshot_task_impls=debug just cargo test test_success_marketplace -- --nocapture