Fix The Justfile Lints #3536
Merged
Fix The Justfile Lints #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
Makes linting more consistent and applies it to all files. Removes some of the redundancy and inconsistent naming in the justfile. Specifically pertaining the the delineation of
lintingandclippycommands. Right now if you ranfmt_lintit ranfmtthenclippy, but the individuallintcommand has distinct behavior, so the disambiguation that this PR adds makes it slightly more clear.Also, the CI for
lint.ymlwas not using the just command and instead was running a rawcargocommand, so any changes to the justfile, and subsequent lints, would not be captured.This PR does not:
Key places to review: