[AUDIT] - Investigate Double View Update from View Sync task #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeiannucci
changed the title
bfish713
reviewed
Aug 2, 2024
lukeiannucci
force-pushed
the
li/remove-double-view-update
branch
from
8211189 to
206f2cc
Compare
jparr721
reviewed
Aug 5, 2024
jparr721
approved these changes
Aug 5, 2024
shamb0
pushed a commit
to shamb0/HotShot
that referenced
this pull request
Aug 6, 2024
…oSystems#3532) * remove double view update from sync task * add expected views to fail, and set the threshold for how many nodes enter view sync * rename and cleanup * run formatter * add spacing
shamb0
added a commit
to shamb0/HotShot
that referenced
this pull request
Aug 6, 2024
parent 4d7965a author RK <[email protected]> 1722937109 +0530 committer shamb0 <[email protected]> 1722937948 +0530 remove glitches [AUDIT] - Investigate Double View Update from View Sync task (EspressoSystems#3532) * remove double view update from sync task * add expected views to fail, and set the threshold for how many nodes enter view sync * rename and cleanup * run formatter * add spacing remove glitches Refactor code: reviewed and removed duplicates Signed-off-by: shamb0 <[email protected]> fix:: Implement graceful shutdown for Byzantine integration tests in tokio and async-std Signed-off-by: shamb0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3463
This PR:
We have added logic to properly handle fetching blocks when a node is the the leader two views in a row (see #3462). Now, we can remove the double update from View Sync and write a integration test to verify when view sync triggers after 2 failures that we fetch both blocks for the next leader who will lead 2 consecutive views
This PR does not:
Key places to review: