Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tj/typos and ordering #3524

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Tj/typos and ordering #3524

merged 5 commits into from
Aug 2, 2024

Conversation

0xkato
Copy link
Contributor

@0xkato 0xkato commented Jul 31, 2024

This PR:

Non-issues from the review.

Correcting typos, variable ordering and removing some superfluous code.

@0xkato 0xkato requested a review from bfish713 as a code owner July 31, 2024 22:23
@CLAassistant
Copy link

CLAassistant commented Jul 31, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jparr721
jparr721 previously approved these changes Aug 1, 2024
View reviewed changes
bfish713
bfish713 requested changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@bfish713 bfish713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a lint failure, can you fix that? and then this should be good to do

@0xkato 0xkato merged commit 4fd0a5a into main Aug 2, 2024
36 checks passed
@0xkato 0xkato deleted the tj/typos_and_ordering branch August 2, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparr721 jparr721 jparr721 approved these changes

@bfish713 bfish713 bfish713 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xkato @CLAassistant @bfish713 @jparr721