[AUDIT][LOW][CX_HARDENING] - Add Bespoke Tests For VoteDependencyHandle

[jparr721]

Closes #3452

This PR:

Currently our vote task tests are not invariant to all possible orderings

Quorum Vote Task has a problem during its units tests where no matter what order the events are received, QuorumProposalValidated is ALWAYS the first event processed when handle_dep_result is called within the dependency task:

Consider this list of events

Inputs
0: DaCertificateRecv(view_number=ViewNumber(2))
1: VIDShareRecv(view_number=ViewNumber(2))
2: QuorumProposalValidated(view_number=ViewNumber(2))

Re-Broadcasts
3: DaCertificateValidated(view_number=ViewNumber(2))
4: VIDShareValidated(view_number=ViewNumber(2))

Outputs
5: QuorumVoteDependenciesValidated(view_number=ViewNumber(2))
6: ValidatedStateUpdated(view_number=ViewNumber(2))
7: QuorumVoteSend(view_number=ViewNumber(2))

The events vec will always shuffle DaCertificateRecv and VIDShareRecv accordingly, but QuorumProposalValidated is ALWAYS first, even when it comes last in the inputs. This is due to how the events are processed in the unit test:

Starting here, we begin processing events. If you notice, however, we deviate our behavior slightly from the Quorum Proposal Task here. The event is optional because of these:

• DaCertificateValidated
• VidShareValidated

The proposal task has no use for validation, but voting does, which means its custom events incur a rebroadcast delay (however slight), but only for the above tasks, not QuorumProposalValidated, leading to it always being the first event received by the spawned dependency tasks. As a result, these events beget None in the above code block when creating the background task in the voting logic, but the value is ALWAYS Some and, hence, does not use Option in the same function for the proposal task.

Because of this, during the testing, the events are applied instantly, meaning that the infinitessimal delay in broadacast to create the new DaCertificate and VidShare events always results in QuorumProposalValidated getting there first, meaning that we cannot ever have a test where this does not happen first in the current logic.

This PR adds a specific test to the vote dependency task with all permutations.

This PR does not:

Key places to review: