Add Byzantine Test where we have a dishonest leader #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfish713
reviewed
Jul 30, 2024
lukeiannucci
force-pushed
the
li/byzantine-test-dishonest-leader
branch
from
d8ca319 to
319bbf6
Compare
|
I see that your adding the expected views to fail but I think it's missing the most important part. The check you have just says it's ok to have a failed view if it's expected. I think for byzantine tests we want the check to also make sure that we don't succeed in a view we expected to fail. Maybe improving the safety task with this can be a follow up |
jparr721
reviewed
Aug 2, 2024
bfish713
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3515
This PR:
Uses byzantine trait in testing framework to create a dishonest leader that will replace proposed QC with a QC from a previous view
This PR does not:
Key places to review:
tests/tests_1/test_with_failures_2.rsI added the integration test at the bottom to test dishonest leader