Ungate dependency task modules #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
In a separate PR, I was mildly surprised to see that
just cargo checkdid not produce any errors for the dependency task modules when making a type change.I don't believe there's any reason to gate the dependency task modules themselves; the main thing we want to gate is whether the dependency tasks are spawned in HotShot (which is already gated). This PR removes the gating on the modules.
This PR does not:
Dependency tasks will still not run unless the feature is enabled; this PR just prevents having to run
cargo checktwice (with and without the feature).Key places to review: