[AUDIT][Med/Low Severity] Fix race condition in state update for block building #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparr721
commented
Jul 29, 2024
| @@ -95,6 +94,7 @@ async fn test_quorum_proposal_recv_task() { | |||
| proposals[1].data.clone(), | |||
| leaves[0].clone(), | |||
| )), | |||
| exact(ViewChange(ViewNumber::new(2))), | |||
There was a problem hiding this comment.
This is a serial output, so this test changed but the liveness test did not need to.
lukaszrzasik
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
Hotshot initiates a block build request when a node is the leader of the next view. This process is handled via the
wait_for_blockfunction call. However, a race condition exists concerning the timing of reads and writes to thevalidated_state_map.When
validate_proposal_safety_and_livenessis called, it can update thevalidated_state_mapafter theViewChangefrom theupdate_viewfunction is processed. This results inwait_for_blockreading stale state as the parent during the while loop lookup.This PR fixes the issue by moving the
update_viewcall to happen after the validated state update has occurred and it also adds another call site to the liveness branch.This PR does not:
Key places to review: